-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🏃 Refactor healthcheck logic into new package #1
🏃 Refactor healthcheck logic into new package #1
Conversation
cb49e6c
to
77e913c
Compare
bbe1bf8
to
1a496d3
Compare
@@ -1,5 +1,5 @@ | |||
/* | |||
Copyright The Kubernetes Authors. | |||
Copyright 2020 The Kubernetes Authors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary for make verify
to pass
@@ -1,9 +1,12 @@ | |||
/* | |||
Copyright 2020 The Kubernetes Authors. | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Necessary for make verify
to pass
@@ -1,3 +1,19 @@ | |||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing boilerplate
Apart from my response to the open question, lgtm. Really nice refactor! |
1a496d3
to
0320c9c
Compare
Signed-off-by: Chuck Ha <chuckh@vmware.com>
0320c9c
to
26e7b3b
Compare
[D2IQ-88840] check on hash values before committing changes
Signed-off-by: Chuck Ha chuckh@vmware.com
What this PR does / why we need it:
This PR consolidates some of the logic found int he reconciler into a ManagementCluster idea and Cluster idea. The attempt is to keep logic out of the reconciler. This will aid in unit testing as well as reconciler readability.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to kubernetes-sigs#2016
cc @detiber @randomvariable